Source control
- master is the dev branch. If a new release was just cut, master might be the current release. Once work is needed on the next release a branch will be created. Branch names must follow the convention: GROUPER_2_3_0
- When committing (pull request or direct commit)
Java
- There is are eclipse formatting and prefs files in grouper/misc/eclipse
- Never use tabs, only 2 spaces
- Use curlies always e.g. for loops and if statements
- Try to be explicit in naming classes and variables
- Comment a lot
- Always have javadoc
- For new code don't commit if there are warnings in eclipse
- Generally we use unchecked exceptions
- Keep things backwards compatible generally, deprecate if needed
- Use explicit names, dont abbreviate too much
UI
- Try not to use javascript, use the ajax API to write logic in Java and views in JSP
See also