Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Install web IDE
  • No spell check
  • Compare / patch - ignore whitepsace
  • Do not enable folding
  • 2 spaces for tabs
  • Install egit (or git plugin), if not there already
  • Content assist -> uncheck single completions automatically
  • Web browser, use external
  • code templates - catch block has nothing (no printStackTrace()
  • git
    • include untracked file
    • auto stage deleted files
    • auto crlf
  • java errors/warnings
    • unqualified access to instance: warn
    • serializable class without id: ignore
    • possible boolean assignment: warn
    • field declaration hides another field: warn
    • local var hides another field (include constructor, setters
    • unnecessary else: warning
    • unnecessary cast or instanceof: warning
    • Unnecessary code -> Unused private member -> warning
    • Generic Types --> Unchecked generic type operation -> warning
    • missing @Override: warning
    • missing @Deprecated: warning
    • warn if not all enums used in switch (tell people)
    • missing javadoc (private+): warning
  • Javadoc missing should be warnings
  • Increase timeouts of tomcat
  • Maven - errors / warnings - ignore plugin execution not covered by lifecycle configuration
  • Skip breakpoints on run to line
  • Always launch previously launched application
  • Disable content completions except error
  • Dont ignore .* resources in package explorer
  • Dont escape text when pasting string literals
  • Java - editor - content assist - advanced - Java proposals and content assist

Java

  • There is are eclipse formatting and prefs files in grouper/misc/eclipse
  • There are xml configurations for checkstyle under grouper-parent/src/checkstyle. You can add the checkstyle plugin for either Eclipse (more instructions here) or IntelliJ, and it will scan and warn of style issues, either on demand or in the background. Use "grouper-parent/src/checkstyle/checkstyle.xml" for new or recent files. The other configuration "grouper-parent/src/checkstyle/checkstyle-legacy.xml" only checks for the license and a few minor issues, and is more geared toward older files that have more style problems but are unlikely to be fixed. To use Maven to scan all files in a project, use `mvn checkstyle:checkstyle` for legacy checks, or `mvn checkstyle:checkstyle -Dcheckstyle.config.location=src/checkstyle/checkstyle.xml` to scan with the more rigorous checks. This will work from any project directory, or in grouper-parent to scan all projects.
  • Never use tabs, only 2 spaces
  • Use curlies always e.g. for loops and if statements
  • Try to be explicit in naming classes and variables, try not to abbreviate
    • If a field or variable can be named the same as its type it might make things more clear or easier to read later.
    • e.g. if the type is "GrouperAttestationAttribute", maybe name it "grouperAttestationAttribute" instead of just "attribute"
  • Comment a lot
  • Always have javadoc
  • For new code don't commit if there are warnings in eclipse
  • Generally we use unchecked exceptions
  • Keep things backwards compatible generally, deprecate if needed

...